Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unwraps inside verify_gnark_proof (issue 1830) #1834

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: Remove unwraps inside verify_gnark_proof (issue 1830) #1834

merged 1 commit into from
Dec 3, 2024
+14 −8

Conversation

fedemagnani
Copy link
Contributor

@fedemagnani fedemagnani commented Dec 1, 2024 •
edited
Loading

Motivation

Closes #1830

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@fedemagnani fedemagnani changed the title issue 1830 [BUG] Remove unwraps inside verify_gnark_proof (issue 1830) Dec 1, 2024
@fedemagnani fedemagnani changed the title [BUG] Remove unwraps inside verify_gnark_proof (issue 1830) fix: Remove unwraps inside verify_gnark_proof (issue 1830) Dec 1, 2024
@nhtyy nhtyy added next-release A PR or an issue that should resolved before the next major release bug Something isn't working core Issues or PRs relating to SP1 core labels Dec 3, 2024
@nhtyy nhtyy merged commit 013c24e into succinctlabs:dev Dec 3, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhtyy nhtyy nhtyy approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core Issues or PRs relating to SP1 core next-release A PR or an issue that should resolved before the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verify_gnark_proof can cause panic if the proof is wrong
2 participants
@fedemagnani @nhtyy